zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r344015308
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -461,16 +462,16 @@ AbstractInvokable getInvokable() {
return invokable;
}
- public StackTraceElement[] getStackTraceOfExecutingThread() {
- final AbstractInvokable invokable = this.invokable;
-
- if (invokable == null) {
- return new StackTraceElement[0];
+ @Override
+ public boolean isBackPressured() {
+ if (invokable == null ||
consumableNotifyingPartitionWriters.length == 0) {
+ return true;
}
-
- return invokable.getExecutingThread()
- .orElse(executingThread)
- .getStackTrace();
+ final CompletableFuture<?>[] outputFutures = new
CompletableFuture[consumableNotifyingPartitionWriters.length];
+ for (int i = 0; i < outputFutures.length; ++i) {
+ outputFutures[i] =
consumableNotifyingPartitionWriters[i].isAvailable();
+ }
+ return CompletableFuture.allOf(outputFutures).isDone();
Review comment:
The return value is reverse. If all the outputs are available, then it
should return false. The return value `true` means back pressured.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
