zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r344018872
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/BackPressureSampleableTask.java
##########
@@ -22,13 +22,13 @@
import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
/**
- * Task interface used by {@link StackTraceSampleService} for back pressure
tracking.
+ * Task interface used by {@link BackPressureSampleService} for back pressure
tracking.
*/
-interface StackTraceSampleableTask {
+public interface BackPressureSampleableTask {
boolean isRunning();
- StackTraceElement[] getStackTrace();
+ boolean isBackPressured();
ExecutionAttemptID getExecutionId();
Review comment:
This interface method is also not very necessary, and the only usage atm is
for throwing exception. I guess we can remove it as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
