KurtYoung commented on a change in pull request #10123:
[FLINK-14665][table-planner-blink] Support computed column for create…
URL: https://github.com/apache/flink/pull/10123#discussion_r344424391
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/schema/FlinkRelOptTable.scala
##########
@@ -44,15 +42,16 @@ import org.apache.calcite.util.{ImmutableBitSet, Util}
import java.util.{List => JList, Set => JSet}
import scala.collection.JavaConversions._
+import scala.collection.JavaConverters._
/**
* [[FlinkRelOptTable]] wraps a [[FlinkTable]]
*
- * @param schema the [[RelOptSchema]] this table belongs to
- * @param rowType the type of rows returned by this table
- * @param names the identifier for this table. The identifier must be
unique with
- * respect to the Connection producing this table.
- * @param table wrapped flink table
+ * @param schema the [[RelOptSchema]] this table belongs to
Review comment:
revert this? I didn't see any problem with old format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
