KurtYoung commented on a change in pull request #10123:
[FLINK-14665][table-planner-blink] Support computed column for create…
URL: https://github.com/apache/flink/pull/10123#discussion_r344421938
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LegacyTypeInformationType.java
##########
@@ -50,7 +50,14 @@
private final TypeInformation<T> typeInfo;
public LegacyTypeInformationType(LogicalTypeRoot logicalTypeRoot,
TypeInformation<T> typeInfo) {
- super(true, logicalTypeRoot);
+ this(true, logicalTypeRoot, typeInfo);
+ }
+
+ public LegacyTypeInformationType(
+ boolean nullable,
Review comment:
Could you explain why you adding this? AFAIK TypeInformation don't have
nullability, and I also can't find any place calling this modified constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
