tweise commented on issue #10138: [FLINK-14635][e2e tests] Use non-relocated imports for AWS SDK Kinesis classes in tests. URL: https://github.com/apache/flink/pull/10138#issuecomment-552257775 @StephanEwen I understand the motivation to make the imports display as valid in the IDE. Unfortunately the PR in its current form introduces problems that IMO offset that gain. The Kinesis dependency (with version) is repeated along with the shading, and that can easily go out of sync. The `Records` utility to return stringified records (and does depend on the relocated classes) is also a bit of a hack. Since there isn't a silver bullet and the proposal already adda code that is only needed for this test to the connector module, how about moving the entire `KinesisPubsubClient`? And maybe there is a way to place it in the test module?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
