walterddr commented on a change in pull request #10143: [FLINK-13184]Starting a
TaskExecutor blocks the YarnResourceManager's main thread
URL: https://github.com/apache/flink/pull/10143#discussion_r344503690
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -491,41 +492,9 @@ static ContainerLaunchContext createTaskExecutorContext(
flinkJar = registerLocalResource(fs, remoteJarPath);
}
- // register conf with local fs
- final LocalResource flinkConf;
Review comment:
Q: This seems to be a relatively small content (especially if we consider
this can be constructed as a Stringify argument using the
`getDynamicProperties` code. Can I assume that the main time saver here is the
sync interaction with the DFS during `setupLocalResource`?
If the above assumption is true, would changing the NMClient / AMRMClient to
use async resolve the issue already?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
