KurtYoung commented on a change in pull request #10022:
[FLINK-14135][hive][orc] Introduce orc ColumnarRow reader for hive connector
URL: https://github.com/apache/flink/pull/10022#discussion_r345181437
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/vector/VectorizedColumnBatch.java
##########
@@ -123,7 +123,10 @@ public Decimal getDecimal(int rowId, int colId, int
precision, int scale) {
return null;
}
- if (Decimal.is32BitDecimal(precision)) {
+ ColumnVector column = columns[colId];
Review comment:
make sure this class is all covered by tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
