azagrebin commented on a change in pull request #9975: 
[FLINK-14477][coordination] Implement promotion logic on TaskExecutor 
URL: https://github.com/apache/flink/pull/9975#discussion_r345294650
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/TaskExecutorPartitionTrackerImpl.java
 ##########
 @@ -24,12 +24,18 @@
 import org.apache.flink.util.Preconditions;
 
 import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
 
 /**
  * Utility for tracking partitions and issuing release calls to task executors 
and shuffle masters.
  */
 public class TaskExecutorPartitionTrackerImpl extends 
AbstractPartitionTracker<JobID, TaskExecutorPartitionInfo> implements 
TaskExecutorPartitionTracker {
 
+       private final Map<DataSetMetaInfo, Set<ResultPartitionID>> 
clusterPartitions = new HashMap<>();
 
 Review comment:
   Where do we need this indexing? for the report to RM? Is 
`IntermediateDataSetID` not enough for this indexing?
   which other info will be added to `DataSetMetaInfo` and how it differs from 
`TaskExecutorPartitionInfo`?
   Maybe, some comments could be added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to