azagrebin commented on a change in pull request #9975:
[FLINK-14477][coordination] Implement promotion logic on TaskExecutor
URL: https://github.com/apache/flink/pull/9975#discussion_r345888198
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/TaskExecutorPartitionTrackerImpl.java
##########
@@ -19,13 +19,29 @@
import org.apache.flink.api.common.JobID;
import org.apache.flink.runtime.jobgraph.IntermediateDataSetID;
+import org.apache.flink.runtime.shuffle.ShuffleEnvironment;
+import org.apache.flink.util.CollectionUtil;
import org.apache.flink.util.Preconditions;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+
/**
* Utility for tracking partitions and issuing release calls to task executors
and shuffle masters.
*/
public class TaskExecutorPartitionTrackerImpl extends
AbstractPartitionTracker<JobID, TaskExecutorPartitionInfo> implements
TaskExecutorPartitionTracker {
+ private final Map<TaskExecutorPartitionInfo, Set<ResultPartitionID>>
clusterPartitions = new HashMap<>();
Review comment:
code style nit: always had a feeling we were recently striving to init
things in the constructor, not part of official guide, though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
