[ 
https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974391#comment-14974391
 ] 

ASF GitHub Bot commented on FLINK-7:
------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1255#discussion_r43008448
  
    --- Diff: 
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobGraphGenerator.java
 ---
    @@ -1138,12 +1138,13 @@ private DistributionPattern 
connectJobVertices(Channel channel, int inputNumber,
                
                if (channel.getShipStrategy() == 
ShipStrategyType.PARTITION_RANGE) {
                        
    -                   final DataDistribution dataDistribution = 
channel.getDataDistribution();
    +                   DataDistribution dataDistribution = 
channel.getDataDistribution();
                        if (dataDistribution != null) {
                                
sourceConfig.setOutputDataDistribution(dataDistribution, outputIndex);
                        } else {
    -                           throw new RuntimeException("Range partitioning 
requires data distribution");
    -                           // TODO: inject code and configuration for 
automatic histogram generation
    --- End diff --
    
    As the TODO comment says, here should go the sampling and distribution 
building code :-)


> [GitHub] Enable Range Partitioner
> ---------------------------------
>
>                 Key: FLINK-7
>                 URL: https://issues.apache.org/jira/browse/FLINK-7
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Runtime
>            Reporter: GitHub Import
>            Assignee: Chengxiang Li
>             Fix For: pre-apache
>
>
> The range partitioner is currently disabled. We need to implement the 
> following aspects:
> 1) Distribution information, if available, must be propagated back together 
> with the ordering property.
> 2) A generic bucket lookup structure (currently specific to PactRecord).
> Tests to re-enable after fixing this issue:
>  - TeraSortITCase
>  - GlobalSortingITCase
>  - GlobalSortingMixedOrderITCase
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/7
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels: core, enhancement, optimizer, 
> Milestone: Release 0.4
> Assignee: [fhueske|https://github.com/fhueske]
> Created at: Fri Apr 26 13:48:24 CEST 2013
> State: open



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to