GJL commented on a change in pull request #10152: [FLINK-14466][runtime] Let
YarnJobClusterEntrypoint use user code class loader
URL: https://github.com/apache/flink/pull/10152#discussion_r346305102
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
##########
@@ -126,7 +130,18 @@ public void testCopyFromLocalRecursiveWithoutScheme()
throws Exception {
final FileSystem targetFileSystem =
hdfsRootPath.getFileSystem(hadoopConfig);
final Path targetDir = targetFileSystem.getWorkingDirectory();
- testCopyFromLocalRecursive(targetFileSystem, targetDir,
tempFolder, false);
+ testCopyFromLocalRecursive(targetFileSystem, targetDir,
LOCAL_RESOURCE_DIRECTORY, tempFolder, false);
+ }
+
+ /**
+ * Verifies that a single file is properly copied.
+ */
+ @Test
+ public void testCopyAFileFromLocal() throws IOException,
URISyntaxException, InterruptedException {
Review comment:
I currently don't see how this test adds additional coverage. If we can
upload a directory recursively, we can also assume that uploading a single file
in a directory works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
