GJL commented on a change in pull request #10152: [FLINK-14466][runtime] Let 
YarnJobClusterEntrypoint use user code class loader
URL: https://github.com/apache/flink/pull/10152#discussion_r346290408
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
 ##########
 @@ -737,6 +739,13 @@ private ApplicationReport startAppMaster(
 
                addEnvironmentFoldersToShipFiles(systemShipFiles);
 
+               checkState(userJarInclusion != 
YarnConfigOptions.UserJarInclusion.DISABLED || isUsrLibDirIncludedInShipFiles(),
+                       String.format("This is an illegal ship directory : %s. 
When setting the %s to %s " +
 
 Review comment:
   Same here, see
   
   ```
   public static void checkState(boolean condition,
                        @Nullable String errorMessageTemplate,
                        @Nullable Object... errorMessageArgs)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to