TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary and Yarn public distributed cache to accelerate flink
submission.
URL: https://github.com/apache/flink/pull/10193#discussion_r346641243
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -149,61 +155,79 @@ public static void setupYarnClassPath(Configuration
conf, Map<String, String> ap
String appId,
Path localSrcPath,
Path homedir,
- String relativeTargetPath) throws IOException {
-
- File localFile = new File(localSrcPath.toUri().getPath());
- if (localFile.isDirectory()) {
- throw new IllegalArgumentException("File to copy must
not be a directory: " +
- localSrcPath);
- }
+ String relativeTargetPath,
+ @Nullable FileStatus preUploadedFileStatus) throws IOException {
Review comment:
I think we should separate register pre-uploaded files into another method
instead just hacking a huge if-else block. If you take a close look you will
find this two code path share little code and pre-uploaded path even doesn't
use most of the parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
