TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary and Yarn public distributed cache to accelerate flink
submission.
URL: https://github.com/apache/flink/pull/10193#discussion_r346641389
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -509,7 +536,8 @@ static ContainerLaunchContext createTaskExecutorContext(
appId,
new Path(taskManagerConfigFile.toURI()),
homeDirPath,
- "").f1;
+ "",
+ null).f1;
Review comment:
With my comment above we don't need to pass most of `null` default as here
and else where.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
