zhuzhurk commented on a change in pull request #10179: [FLINK-14734][runtime]
Add a ResourceSpec in SlotSharingGroup to describe its overall resources
URL: https://github.com/apache/flink/pull/10179#discussion_r346934468
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotSharingGroup.java
##########
@@ -38,14 +40,20 @@
private final SlotSharingGroupId slotSharingGroupId = new
SlotSharingGroupId();
+ /** Represents resources of all tasks in the group. Default to be zero.
+ * Any task with UNKNOWN resources will turn it to be UNKNOWN. */
+ private ResourceSpec resourceSpec = ResourceSpec.newBuilder(0.0,
0).build();
+
//
--------------------------------------------------------------------------------------------
- public void addVertexToGroup(JobVertexID id) {
- this.ids.add(id);
+ public void addVertexToGroup(final JobVertex jobVertex) {
Review comment:
Agreed. Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
