zentol commented on a change in pull request #10230: 
[FLINK-14803][metrics]Support Consistency Level for InfluxDB metrics
URL: https://github.com/apache/flink/pull/10230#discussion_r347161949
 
 

 ##########
 File path: 
flink-metrics/flink-metrics-influxdb/src/main/java/org/apache/flink/metrics/influxdb/InfluxdbReporterOptions.java
 ##########
 @@ -57,6 +59,15 @@
                .defaultValue("")
                .withDescription("(optional) the InfluxDB retention policy for 
metrics");
 
+       public static final ConfigOption<String>  CONSISTENCY = ConfigOptions
 
 Review comment:
   ConfigOptions now support enums, which should simplify this PR a bit. the 
config docs generator also automatically extracts possible values, so the 
description can be slimmed down as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to