zentol commented on a change in pull request #10230:
[FLINK-14803][metrics]Support Consistency Level for InfluxDB metrics
URL: https://github.com/apache/flink/pull/10230#discussion_r348452755
##########
File path:
flink-metrics/flink-metrics-influxdb/src/main/java/org/apache/flink/metrics/influxdb/InfluxdbReporterOptions.java
##########
@@ -57,6 +59,13 @@
.defaultValue("")
.withDescription("(optional) the InfluxDB retention policy for
metrics");
+ public static final ConfigOption<InfluxDB.ConsistencyLevel>
CONSISTENCY = ConfigOptions
+ .key("consistency")
+ .enumType(InfluxDB.ConsistencyLevel.class)
+ .defaultValue(InfluxDB.ConsistencyLevel.ONE)
+ .withDescription(String.format("(optional) InfluxDB consistency
level for metrics. default is %s",
Review comment:
the default is also automatically documented; so this can just say
"(optional) the InfluxDB consistency level for metrics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
