danny0405 commented on a change in pull request #10224: [FLINK-14716][table-planner-blink] Cooperate computed column with push down rules URL: https://github.com/apache/flink/pull/10224#discussion_r347267471
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/catalog/QueryOperationCatalogViewTable.java ########## @@ -18,88 +18,58 @@ package org.apache.flink.table.planner.catalog; -import org.apache.flink.annotation.Internal; -import org.apache.flink.table.api.TableSchema; import org.apache.flink.table.catalog.QueryOperationCatalogView; +import org.apache.flink.table.operations.QueryOperation; +import org.apache.flink.table.operations.TableSourceQueryOperation; import org.apache.flink.table.planner.calcite.FlinkRelBuilder; -import org.apache.flink.table.planner.calcite.FlinkTypeFactory; -import org.apache.flink.table.planner.plan.schema.FlinkTable; +import org.apache.flink.table.planner.plan.schema.FlinkPreparingTableBase; import org.apache.flink.table.planner.plan.stats.FlinkStatistic; -import org.apache.flink.table.planner.utils.JavaScalaConversionUtil; -import org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter; -import org.apache.flink.table.types.logical.LogicalType; -import org.apache.calcite.plan.RelOptTable; +import org.apache.calcite.plan.RelOptSchema; +import org.apache.calcite.plan.RelOptTable.ToRelContext; Review comment: I have to import that, or the compile would fail, i think it is because the shade plugin. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
