danny0405 commented on a change in pull request #10224:
[FLINK-14716][table-planner-blink] Cooperate computed column with push down
rules
URL: https://github.com/apache/flink/pull/10224#discussion_r347776419
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/FlinkCalciteCatalogReader.java
##########
@@ -62,17 +80,181 @@ public FlinkCalciteCatalogReader(
if (originRelOptTable == null) {
return null;
} else {
- // Wrap FlinkTable as FlinkRelOptTable to use in query
optimization.
- FlinkTable table =
originRelOptTable.unwrap(FlinkTable.class);
+ // Wrap as FlinkPreparingTableBase to use in query
optimization.
+ CatalogSchemaTable table =
originRelOptTable.unwrap(CatalogSchemaTable.class);
if (table != null) {
- return FlinkRelOptTable.create(
- originRelOptTable.getRelOptSchema(),
- originRelOptTable.getRowType(),
+ return
toPreparingTable(originRelOptTable.getRelOptSchema(),
originRelOptTable.getQualifiedName(),
+ originRelOptTable.getRowType(),
table);
} else {
return originRelOptTable;
}
}
}
+
+ /**
+ * Translate this {@link CatalogSchemaTable} into Flink source table.
+ */
+ private static FlinkPreparingTableBase toPreparingTable(
+ RelOptSchema relOptSchema,
+ List<String> names,
+ RelDataType rowType,
+ CatalogSchemaTable table) {
+ if (table.isTemporary()) {
Review comment:
Yep, thanks, let me refactor one of them out !!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
