azagrebin commented on a change in pull request #10034: [FLINK-14400] Shrink
scope of MemoryManager from TaskExecutor to slot
URL: https://github.com/apache/flink/pull/10034#discussion_r347277101
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1459,7 +1420,7 @@ public void
testReconnectionAttemptIfExplicitlyDisconnected() throws Exception {
*/
@Test
public void testInitialSlotReport() throws Exception {
- final TaskSlotTable taskSlotTable = new
TaskSlotTable(Collections.singleton(ResourceProfile.ANY), timerService);
+ final TaskSlotTable taskSlotTable =
TaskSlotUtils.createTaskSlotTable(1);
Review comment:
they all use the default timer service, same as in the builder by default,
which is closed when TM terminates and slot table is stopped. I will add a
hotfix commit to remove this test class field `timerService` as it is redundant
after this refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
