azagrebin commented on a change in pull request #10034: [FLINK-14400] Shrink
scope of MemoryManager from TaskExecutor to slot
URL: https://github.com/apache/flink/pull/10034#discussion_r347862174
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlot.java
##########
@@ -305,4 +321,23 @@ public String toString() {
return "TaskSlot(index:" + index + ", state:" + state + ",
resource profile: " + resourceProfile +
", allocationId: " + (allocationId != null ?
allocationId.toString() : "none") + ", jobId: " + (jobId != null ?
jobId.toString() : "none") + ')';
}
+
+ @Override
+ public void close() {
+ verifyMemoryFreed();
Review comment:
I cannot come up with any valid use-cases for this check to fail and firstly
I had an assertion. I had some failing test cases previously (probably for some
new blink code) but CI does not fail anymore, they might have already been
fixed. I tried CI with a commit inserting the assertion:
https://travis-ci.org/azagrebin/flink/builds/613505573. It is also green.
Anyways, as discussed offline, memory leak after finishing task should not
fail the whole TM but we have to provide a warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
