azagrebin commented on a change in pull request #10197:
[FLINK-14503][coordination] Add partition report to heartbeat
URL: https://github.com/apache/flink/pull/10197#discussion_r347300552
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/TaskExecutorPartitionTrackerImpl.java
##########
@@ -42,12 +42,12 @@ public
TaskExecutorPartitionTrackerImpl(ShuffleEnvironment<?, ?> shuffleEnvironm
}
@Override
- public void startTrackingPartition(JobID producingJobId,
ResultPartitionID resultPartitionId, IntermediateDataSetID
intermediateDataSetId) {
+ public void startTrackingPartition(JobID producingJobId,
ResultPartitionID resultPartitionId, IntermediateDataSetID
intermediateDataSetId, int numberOfPartitions) {
Review comment:
it could be then just:
`startTrackingPartition(JobID,
TaskExecutorPartitionInfo/ResultPartitionDeploymentDescriptor)`
like in JM.
`TaskExecutorPartitionInfo` could have a builder or factory method.
Maybe we could even track RPDD instead of `TaskExecutorPartitionInfo` if it
is enough in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
