azagrebin commented on a change in pull request #10197: 
[FLINK-14503][coordination] Add partition report to heartbeat
URL: https://github.com/apache/flink/pull/10197#discussion_r347311976
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
 ##########
 @@ -519,7 +523,22 @@ public void testHeartbeatSlotReporting() throws Exception 
{
                        .setTaskStateManager(localStateStoresManager)
                        .build();
 
-               final TaskExecutor taskManager = 
createTaskExecutor(taskManagerServices);
+               final ClusterPartitionReport.ClusterPartitionReportEntry 
clusterPartitionReportEntry =
+                       new ClusterPartitionReport.ClusterPartitionReportEntry(
+                               new IntermediateDataSetID(),
+                               Collections.singleton(new ResultPartitionID()),
+                               4);
+
+               final ClusterPartitionReport clusterPartitionReport = new 
ClusterPartitionReport(Collections.singletonList(clusterPartitionReportEntry));
+
+               final TaskExecutorPartitionTracker partitionTracker = new 
TaskExecutorPartitionTrackerImpl(taskManagerServices.getShuffleEnvironment()) {
 
 Review comment:
   separate method: `partitionTracker = 
createTestingTaskExecutorPartitionTracker()`
   ...
   `assertEquals(partitionTracker.createClusterPartitionReport(), 
actualClusterPartitionReport);`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to