HuangZhenQiu commented on a change in pull request #10240: [FLINK-14841][table]
add create and drop function ddl in SQL parser
URL: https://github.com/apache/flink/pull/10240#discussion_r347725138
##########
File path:
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
##########
@@ -177,6 +177,87 @@ SqlDescribeDatabase SqlDescribeDatabase() :
}
+SqlCreate SqlCreateFunction(Span s, boolean replace) :
+{
+ SqlIdentifier functionName = null;
+ SqlCharStringLiteral functionClassName = null;
+ String functionLanguage = null;
Review comment:
If we define language enum in sql parser module. It can't be accessed in api
module. Thus, I would prefer to keep the value as String here, and add the enum
in api module. We may do the transform in SqlToOperationConverter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
