HuangZhenQiu commented on a change in pull request #10240: [FLINK-14841][table] add create and drop function ddl in SQL parser URL: https://github.com/apache/flink/pull/10240#discussion_r347725696
########## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateFunction.java ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser.ddl; + +import org.apache.flink.sql.parser.ExtendedSqlNode; +import org.apache.flink.sql.parser.error.SqlValidateException; + +import org.apache.calcite.sql.SqlCharStringLiteral; +import org.apache.calcite.sql.SqlCreate; +import org.apache.calcite.sql.SqlIdentifier; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlOperator; +import org.apache.calcite.sql.SqlSpecialOperator; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.calcite.util.ImmutableNullableList; + +import javax.annotation.Nonnull; + +import java.util.List; + +import static java.util.Objects.requireNonNull; + +/** + * CREATE FUNCTION DDL sql call. + */ +public class SqlCreateFunction extends SqlCreate implements ExtendedSqlNode { + + public static final SqlSpecialOperator OPERATOR = new SqlSpecialOperator("CREATE FUNCTION", SqlKind.CREATE_FUNCTION); + + private final SqlIdentifier functionName; + + private final SqlCharStringLiteral functionClassName; + + private final String functionLanguage; + + private final boolean hasTemporary; + + private final boolean isSystemFunction; + + public SqlCreateFunction( + SqlParserPos pos, + SqlIdentifier functionName, + SqlCharStringLiteral functionClassName, + String functionLanguage, + boolean ifNotExists, + boolean hasTemporary, + boolean isSystemFunction) { + super(OPERATOR, pos, false, ifNotExists); Review comment: Good catch ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
