danny0405 commented on a change in pull request #10224:
[FLINK-14716][table-planner-blink] Cooperate computed column with push down
rules
URL: https://github.com/apache/flink/pull/10224#discussion_r347795214
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/sources/TableSourceUtil.scala
##########
@@ -137,22 +122,25 @@ object TableSourceUtil {
/**
* Returns schema of the selected fields of the given [[TableSource]].
*
- * @param tableSchema The [[TableSchema]] to derive the names and data
types.
- * This table schema should include all the columns,
say,
- * computed columns should also be included.
- * @param tableSource The [[TableSource]] to derive time attributes.
- * @param selectedFields The indices of all selected fields. None, if all
fields are selected.
- * @param streaming Flag to determine whether the schema of a stream or
batch table is created.
- * @return The schema for the selected fields of the given [[TableSource]].
+ * @param typeFactory Type factory to create the type
+ * @param fieldNameArray Field names to build the row type
+ * @param fieldDataTypeArray Field data types to build the row type
+ * @param tableSource The [[TableSource]] to derive time attributes
+ * @param selectedFields The indices of all selected fields. None, if all
fields are selected
+ * @param streaming Flag to determine whether the schema of
+ * a stream or batch table is created
+ * @return The schema for the selected fields of the given [[TableSource]]
*/
- def getFieldNameType(
- tableSchema: TableSchema,
+ def getSourceRowType(
+ typeFactory: FlinkTypeFactory,
+ fieldNameArray: Array[String],
+ fieldDataTypeArray: Array[DataType],
tableSource: TableSource[_],
selectedFields: Option[Array[Int]],
Review comment:
Yes, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
