HuangXingBo commented on a change in pull request #10126: [FLINK-14590][python]
Unify the working directory of Java process and Python process when submitting
python jobs via "flink run -py"
URL: https://github.com/apache/flink/pull/10126#discussion_r347351634
##########
File path:
flink-python/src/main/java/org/apache/flink/client/python/PythonEnvUtils.java
##########
@@ -188,6 +181,7 @@ public FileVisitResult visitFile(java.nio.file.Path file,
BasicFileAttributes at
*/
public static void createSymbolicLinkForPyflinkLib(java.nio.file.Path
libPath, java.nio.file.Path symbolicLinkPath)
throws IOException {
+ symbolicLinkPath.getParent().toFile().mkdirs();
Review comment:
What about moving this code outside the method. IMHO, we don't need to
create the directory when moving lib jars because the parent directory is
storageDirectory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
