azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime]
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347421276
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -671,112 +601,6 @@ TMSlaves() {
fi
}
-useOffHeapMemory() {
- [[ "`echo ${FLINK_TM_OFFHEAP} | tr '[:upper:]' '[:lower:]'`" == "true" ]]
-}
-
-HAVE_AWK=
-# same as
org.apache.flink.runtime.taskexecutor.TaskManagerServices.calculateNetworkBufferMemory(long
totalJavaMemorySize, Configuration config)
-calculateNetworkBufferMemory() {
Review comment:
Looks like
`NettyShuffleEnvironmentConfiguration#calculateNetworkBufferMemory` still
exists and used only in tests. We should remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
