azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime]
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347356545
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -104,6 +104,18 @@ public static TaskExecutorResourceSpec
resourceSpecFromConfig(final Configuratio
}
}
+ public static boolean isTaskExecutorResourceExplicitlyConfigured(final
Configuration config) {
+ if (isTaskHeapMemorySizeExplicitlyConfigured(config) &&
isManagedMemorySizeExplicitlyConfigured(config)) {
Review comment:
the function can return logic `or - ||` of these `ifs`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
