kl0u commented on a change in pull request #10251: [FLINK-14851][FLINK-14850]
Implement Executors and wire them to the ContextEnvironment
URL: https://github.com/apache/flink/pull/10251#discussion_r347907050
##########
File path:
flink-core/src/main/java/org/apache/flink/core/execution/Executor.java
##########
@@ -18,20 +18,25 @@
package org.apache.flink.core.execution;
+import org.apache.flink.annotation.Internal;
import org.apache.flink.api.common.JobExecutionResult;
import org.apache.flink.api.dag.Pipeline;
import org.apache.flink.configuration.Configuration;
+import javax.annotation.Nonnull;
+
/**
* The entity responsible for executing a {@link Pipeline}, i.e. a user job.
*/
+@Internal
public interface Executor {
/**
* Executes a {@link Pipeline} based on the provided configuration.
+ *
* @param pipeline the {@link Pipeline} to execute
* @param configuration the {@link Configuration} with the required
execution parameters
* @return the {@link JobExecutionResult} corresponding to the pipeline
execution.
*/
- JobExecutionResult execute(Pipeline pipeline, Configuration
configuration) throws Exception;
+ JobExecutionResult execute(@Nonnull final Pipeline pipeline, @Nonnull
final Configuration configuration) throws Exception;
Review comment:
I know that we enforce nothing with marking it as `final`, we just express
the intentions of the developer that introduced the interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
