kl0u commented on a change in pull request #10251: [FLINK-14851][FLINK-14850]
Implement Executors and wire them to the ContextEnvironment
URL: https://github.com/apache/flink/pull/10251#discussion_r347907526
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/deployment/ClusterClientServiceLoaderTest.java
##########
@@ -57,7 +57,7 @@ public void init() {
@Test
public void testStandaloneClusterClientFactoryDiscovery() {
final Configuration config = new Configuration();
- config.setString(DeploymentOptions.TARGET,
StandaloneClientFactory.ID);
+ config.setString(DeploymentOptions.TARGET,
StandaloneClientFactory.ID.toUpperCase());
Review comment:
Yes, this is mainly to be "future-proof", i.e. guarantee that the next one
who touches this code will respect the contract.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
