godfreyhe commented on a change in pull request #10249: [FLINK-14847][hive]
Support retrieving Hive PK constraints
URL: https://github.com/apache/flink/pull/10249#discussion_r348299336
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -544,6 +544,12 @@ private CatalogBaseTable instantiateCatalogTable(Table
hiveTable, HiveConf hiveC
properties,
comment);
} else {
+ List<String> primaryKey =
client.getPrimaryKey(hiveTable.getDbName(), hiveTable.getTableName(),
+ HiveTableUtil.relyConstraint((byte) 0));
+ // Need a better place to hold the PK constraints. Put
it as a property for now.
Review comment:
there is already a pr: [[FLINK-12846][table-common] Carry primary key
information in TableSchema ](https://github.com/apache/flink/pull/10213) to
solve this, add this info to the comments ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
