Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1214#discussion_r43498784
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamContextEnvironment.java
---
@@ -75,29 +62,31 @@ public JobExecutionResult execute() throws Exception {
@Override
public JobExecutionResult execute(String jobName) throws Exception {
- JobGraph jobGraph;
- if (jobName == null) {
- jobGraph = this.getStreamGraph().getJobGraph();
- } else {
- jobGraph = this.getStreamGraph().getJobGraph(jobName);
- }
-
- transformations.clear();
-
- // attach all necessary jar files to the JobGraph
- for (URL file : jars) {
--- End diff --
Jars and classpaths also need to be attached to the JobGraph of the
non-detached streaming job, right? Wouldn't it be nice to always do that at the
Client? It's always good to avoid multiple branches for doing the same thing.
`Client.getJobGraph(FlinkPlan,..` enables you to pass the streamgraph directly
with the jars and classpaths.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
