Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1214#issuecomment-152989560
It's fine to have separate code for detached and blocking submission where
necessary. I was more concerned with this pull request that it introduces new
code branches which distort the existing submission logic. Wherever possible we
should try to be explicit about the submission code path we're in instead of
mixing them all together.
For instance, you're setting `lastEnv´ on blocking execution but then you
never access it during blocking execution. This is not a clear code style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
