TisonKun commented on a change in pull request #10235: [FLINK-14839][config]
Let JobGraph#classpaths become non-null
URL: https://github.com/apache/flink/pull/10235#discussion_r349414021
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java
##########
@@ -352,8 +353,8 @@ public JobVertex findVertexByID(JobVertexID id) {
*
* @param paths paths of the directories/JAR files required to run the
job on a task manager
*/
- public void setClasspaths(List<URL> paths) {
- classpaths = paths;
+ public void addClasspaths(Collection<URL> paths) {
Review comment:
So for `addJars`. We don't call `addJars` multiple times for now. However,
it fits the abstraction that we firstly instance an empty collection and then
add member per call. If we still using setter and with a null checker the field
cannot be `final` while we don't gain a lot from such mutability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
