TisonKun commented on a change in pull request #10235: [FLINK-14839][config] 
Let JobGraph#classpaths become non-null
URL: https://github.com/apache/flink/pull/10235#discussion_r351236042
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java
 ##########
 @@ -100,7 +101,7 @@
        private final List<PermanentBlobKey> userJarBlobKeys = new 
ArrayList<>();
 
        /** List of classpaths required to run this job. */
-       private List<URL> classpaths = Collections.emptyList();
 
 Review comment:
   OK I can see the problem. Although we can work around by adding another 
field and add some bridge code I don't it is worth to do so because this is 
just a nice to have improvement. A reasonable way in my mind is that we take 
this thing into consideration when we port JobGraph to its protobuf version if 
there will be one. Anyway, defer the effort until we are in a codebase easy to 
do it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to