KurtYoung commented on a change in pull request #10270:
[FLINK-14672][sql-client] Make Executor stateful in sql client
URL: https://github.com/apache/flink/pull/10270#discussion_r349421036
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -347,14 +441,16 @@ public String explainStatement(SessionContext session,
String statement) throws
}
@Override
- public ResultDescriptor executeQuery(SessionContext session, String
query) throws SqlExecutionException {
- final ExecutionContext<?> context =
getOrCreateExecutionContext(session);
- return executeQueryInternal(context, query);
+ public ResultDescriptor executeQuery(String sessionId, String query)
throws SqlExecutionException {
+ final ExecutionContext<?> context =
getExecutionContext(sessionId);
+ return executeQueryInternal(sessionId, context, query);
}
@Override
- public TypedResult<List<Tuple2<Boolean, Row>>>
retrieveResultChanges(SessionContext session,
- String resultId) throws SqlExecutionException {
+ public TypedResult<List<Tuple2<Boolean, Row>>> retrieveResultChanges(
+ String sessionId,
+ String resultId
+ ) throws SqlExecutionException {
Review comment:
nit: format
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
