KurtYoung commented on a change in pull request #10270:
[FLINK-14672][sql-client] Make Executor stateful in sql client
URL: https://github.com/apache/flink/pull/10270#discussion_r349420085
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -200,69 +277,98 @@ public void start() {
}
@Override
- public List<String> listCatalogs(SessionContext session) throws
SqlExecutionException {
- final ExecutionContext<?> context =
getOrCreateExecutionContext(session);
+ public void resetSessionProperties(String sessionId) throws
SqlExecutionException {
+ // Renew the ExecutionContext by using the default environment.
+ this.contextMap.put(sessionId,
createExecutionContext(defaultEnvironment));
Review comment:
reset session property should keep the content which read from session
environment file? Now it looks we also git rid of this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
