[
https://issues.apache.org/jira/browse/FLINK-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979817#comment-16979817
]
Zhu Zhu commented on FLINK-14915:
---------------------------------
I think it's fine to remove the {{JobGraph}} parameter for now. [~tison]
It provides additional information but exposes too much internal
implementations and there can be actions which are not desired to be invoked.
In the next version we can provide needed information for custom
{{SchedulingStrategy}} in a more well-defined way.
> SchedulingStrategyFactory#createInstance might not need to know JobGraph
> ------------------------------------------------------------------------
>
> Key: FLINK-14915
> URL: https://issues.apache.org/jira/browse/FLINK-14915
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
> Reporter: Zili Chen
> Priority: Major
>
> [~zhuzh] [~GJL] I just notice that
> {{SchedulingStrategyFactory#createInstance}} take a parameter {{JobGraph}}
> but neither the parameter is in use nor this class/method should know
> {{JobGraph}}. Could you explain why we need it or we can safely remove the
> parameter so that we get rid of confusing parameter?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
