[
https://issues.apache.org/jira/browse/FLINK-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979855#comment-16979855
]
Zhu Zhu commented on FLINK-14915:
---------------------------------
{{SchedulerBase}} still needs the {{JobGraph}} to build an {{ExecutionGraph}},
so we cannot drop it for now.
What I mean is {{SchedulingStrategy}} which could be customizable by users in
the future, so we should hide unnecessary implementation details if possible.
I can open a PR to remove the {{JobGraph}} parameter from
{{SchedulingStrategyFactory#createInstance}}.
Would you assign it to me?
> SchedulingStrategyFactory#createInstance might not need to know JobGraph
> ------------------------------------------------------------------------
>
> Key: FLINK-14915
> URL: https://issues.apache.org/jira/browse/FLINK-14915
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Coordination
> Reporter: Zili Chen
> Priority: Major
>
> [~zhuzh] [~GJL] I just notice that
> {{SchedulingStrategyFactory#createInstance}} take a parameter {{JobGraph}}
> but neither the parameter is in use nor this class/method should know
> {{JobGraph}}. Could you explain why we need it or we can safely remove the
> parameter so that we get rid of confusing parameter?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
