JingsongLi commented on a change in pull request #10268:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10268#discussion_r349431157
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -644,10 +644,13 @@ public SqlMonotonicity
getMonotonicity(SqlOperatorBinding call) {
OperandTypes.family(SqlTypeFamily.STRING,
SqlTypeFamily.INTEGER),
SqlFunctionCategory.STRING);
+ // TODO: the return type of TO_TIMESTAMP should be TIMESTAMP(9)
Review comment:
I'm confused. This is the internal business of blink. Blink has the ability
to converse without losing precision (this is what we have done).
FLINK-14645 is just an API level thing. It is only one way of API, and there
are still other ways to avoid losing precision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
