JingsongLi commented on a change in pull request #10268:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10268#discussion_r349444678
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/DataFormatConverters.java
##########
@@ -799,27 +811,31 @@ Time toExternalImpl(BaseRow row, int column) {
/**
* Converter for timestamp.
*/
- public static final class TimestampConverter extends
DataFormatConverter<Long, Timestamp> {
+ public static final class TimestampConverter extends
DataFormatConverter<SqlTimestamp, Timestamp> {
private static final long serialVersionUID =
-779956524906131757L;
- public static final TimestampConverter INSTANCE = new
TimestampConverter();
+ public static final TimestampConverter INSTANCE = new
TimestampConverter(3);
- private TimestampConverter() {}
+ private final int precision;
+
+ private TimestampConverter(int precision) {
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
