JingsongLi commented on a change in pull request #10268:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10268#discussion_r349444601
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/DataFormatConverters.java
##########
@@ -691,27 +699,31 @@ LocalTime toExternalImpl(BaseRow row, int column) {
/**
* Converter for LocalDateTime.
*/
- public static final class LocalDateTimeConverter extends
DataFormatConverter<Long, LocalDateTime> {
+ public static final class LocalDateTimeConverter extends
DataFormatConverter<SqlTimestamp, LocalDateTime> {
private static final long serialVersionUID = 1L;
- public static final LocalDateTimeConverter INSTANCE = new
LocalDateTimeConverter();
+ public static final LocalDateTimeConverter INSTANCE = new
LocalDateTimeConverter(3);
- private LocalDateTimeConverter() {}
+ private final int precision;
+
+ private LocalDateTimeConverter(int precision) {
Review comment:
It should be `public`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
