wuchong commented on a change in pull request #10268:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10268#discussion_r349473842
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/functions/utils/UserDefinedFunctionUtils.scala
##########
@@ -728,10 +727,12 @@ object UserDefinedFunctionUtils {
expected.isPrimitive && Primitives.wrap(expected) == candidate ||
candidate == classOf[Date] && (expected == classOf[Int] || expected ==
classOf[JInt]) ||
candidate == classOf[Time] && (expected == classOf[Int] || expected ==
classOf[JInt]) ||
- candidate == classOf[Timestamp] && (expected == classOf[Long] ||
- expected == classOf[JLong]) ||
Review comment:
I think this is a big incompatible change which should be discussed
publicly. Because we encourage users to use long to represent timestamp in UDFs
in
[documentation](https://ci.apache.org/projects/flink/flink-docs-master/dev/table/functions/udfs.html#scalar-functions).
And many users are using in this way, this will affect many users.
IIUC, this pull request doesn't blocked by this change, and can be done in
another JIRA issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
