azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime]
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r350231144
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -692,10 +700,16 @@ public static Configuration
adjustConfigurationForLocalExecution(final Configura
final double shuffleFraction =
getShuffleMemoryRangeFraction(configuration).fraction;
final double managedFraction =
getManagedMemoryRangeFraction(configuration).fraction;
+ final double managedOffHeapFraction;
+ if
(isManagedMemoryOffHeapFractionExplicitlyConfigured(configuration)) {
+ managedOffHeapFraction =
getManagedMemoryOffHeapFraction(configuration);
+ } else {
Review comment:
could we move these changes to 87b97fca [hotfix][runtime] If not specified,
set Total Flink Memory according to JVM free heap memory for MiniCluster. Also,
this will be used in production for local execution, I would suggest to add
tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
