azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime]
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r350248512
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/NettyShuffleEnvironmentConfigurationTest.java
##########
@@ -72,145 +85,6 @@ public void testNetworkRequestBackoffAndBuffers() {
assertEquals(networkConfig.floatingNetworkBuffersPerGate(),
100);
}
- /**
- * Test for {@link
NettyShuffleEnvironmentConfiguration#calculateNetworkBufferMemory(long,
Configuration)} using old
Review comment:
`NettyShuffleEnvironmentConfiguration#calculateNetworkBufferMemory` is till
not removed
could be part of
b5d4267e [FLINK-13986][core][runtime] Remove java codes for legacy memory
calculations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
