zjffdu commented on a change in pull request #10313: [FLINK-14840] Use Executor
interface in SQL cli
URL: https://github.com/apache/flink/pull/10313#discussion_r350233830
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ProgramTargetDescriptor.java
##########
@@ -25,56 +25,28 @@
*/
public class ProgramTargetDescriptor {
- private final String clusterId;
-
private final String jobId;
- private final String webInterfaceUrl;
-
- public ProgramTargetDescriptor(String clusterId, String jobId, String
webInterfaceUrl) {
- this.clusterId = clusterId;
+ public ProgramTargetDescriptor(String jobId) {
this.jobId = jobId;
- this.webInterfaceUrl = webInterfaceUrl;
- }
-
- public String getClusterId() {
- return clusterId;
}
public String getJobId() {
return jobId;
}
- public String getWebInterfaceUrl() {
- return webInterfaceUrl;
- }
-
@Override
public String toString() {
- return String.format(
- "Cluster ID: %s\n" +
- "Job ID: %s\n" +
- "Web interface: %s",
- clusterId, jobId, webInterfaceUrl);
+ return "Job ID: %s\n" + jobId;
Review comment:
I think you are intending to use String.format
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
