kl0u commented on a change in pull request #10313: [FLINK-14840] Use Executor
interface in SQL cli
URL: https://github.com/apache/flink/pull/10313#discussion_r350358914
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectBatchResult.java
##########
@@ -45,23 +46,26 @@
private final String accumulatorName;
private final CollectBatchTableSink tableSink;
private final Object resultLock;
- private final Thread retrievalThread;
- private ProgramDeployer<C> deployer;
private int pageSize;
private int pageCount;
private SqlExecutionException executionException;
private List<Row> resultTable;
+ private ClassLoader classLoader;
private volatile boolean snapshotted = false;
- public MaterializedCollectBatchResult(TableSchema tableSchema,
RowTypeInfo outputType, ExecutionConfig config) {
+ public MaterializedCollectBatchResult(
+ TableSchema tableSchema,
+ RowTypeInfo outputType,
+ ExecutionConfig config,
+ ClassLoader classLoader) {
this.outputType = outputType;
accumulatorName = new AbstractID().toString();
tableSink = new CollectBatchTableSink(accumulatorName,
outputType.createSerializer(config), tableSchema);
resultLock = new Object();
- retrievalThread = new ResultRetrievalThread();
+ this.classLoader = classLoader;
Review comment:
`checkNotNull`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
