kl0u commented on a change in pull request #10313: [FLINK-14840] Use Executor
interface in SQL cli
URL: https://github.com/apache/flink/pull/10313#discussion_r351794477
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
##########
@@ -242,6 +249,36 @@ public EnvironmentInstance createEnvironmentInstance() {
//
--------------------------------------------------------------------------------------------
+ private static Configuration createExecutionConfig(
+ CommandLine commandLine,
+ Options commandLineOptions,
+ List<CustomCommandLine> availableCommandLines) throws
FlinkException {
+
Review comment:
This `options` is only used for logging. Do we need it or we can simply
print the final `executionConfig `?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
