TisonKun commented on issue #10311: [FLINK-14762][client] Enrich JobClient API URL: https://github.com/apache/flink/pull/10311#issuecomment-558414935 > Also we could simply return `CompletableFuture<Void>` from the `JobClient.cancel()` method, instead of moving classes around. On this, I do not have a strong opinion, but do you think that there is any particular reason why returning an `Acknowledge` instead of `Void`? I've ever thought of `Void`. `Void` should work well atm. My concern is 1. If we keep in mind the possibility that a rpc based implementation of JobClient, for current implementation akka doesn't allow null message. Although we don't stick to use akka as rpc implementation, a non-null unit value is better than null representing `Void`. 2. Unfortunately Java doesn't have a builtin non-null unit value so that many of Java projects have to implement their own. I think `Acknowledge` its Flink's unit value which is reasonable to move into flink-core.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
